Remove deprecated function from tests#6536
Conversation
|
Looks like these are super easy to find+fix, so it might not be terrible to just break this. On the other hand, we haven't warned for a release and there is no harm in leaving the code here. Honestly, I don't care what we do here; @zpao do you have any thoughts/preferences? |
|
Yea, we never actually respected the So this is actually an interesting case and will need a slight bit more thought on the best way to do this since we need a different change to made for the 15-stable branch. This is totally fine to go into master as is so I'm going to accept but let's hold off on merging until we document the exact process (would hate for us to lose track of this) |
This has been deprecated since 2013 so it's about time to remove it.
apaatsio
force-pushed
the
remove-deprecated-function
branch
from
137eb2b to
bb7bbb0
Compare
|
@apaatsio updated the pull request. |
Summary: `toBeDOMComponentWithTag` is deprecated and has been replaced by `toBeComponentOfType`. See https://github.com/facebook/react/blob/master/src/test/reactComponentExpect.js#L170-178 Related to facebook/react#6536 Closes #1212 Differential Revision: D3430727 fbshipit-source-id: dc6e50514bc209ef887dc881d373ad60a56607b8
|
Ping @zpao—what’s the solution here? |
ghost
added
the
|
Do we expose reactComponentExpect publicly? I don't think we do, in which case we can probably actually just land this whenever. Otherwise we might want to do a separate PR to land first which adds the warning, then we can take that over to stable. |
|
We don't. |
|
Getting it in as it's not exposed. |
This has been deprecated since 2013 so it's about time to remove it.
6 participants
This has been deprecated since 2013 so it's about time to remove it.